Skip to content
This repository has been archived by the owner on Feb 2, 2022. It is now read-only.

Rewrite buoy front end using Backbone.js #185

Open
2 of 7 tasks
hurtstotouchfire opened this issue Nov 25, 2016 · 8 comments
Open
2 of 7 tasks

Rewrite buoy front end using Backbone.js #185

hurtstotouchfire opened this issue Nov 25, 2016 · 8 comments
Milestone

Comments

@hurtstotouchfire
Copy link
Contributor

hurtstotouchfire commented Nov 25, 2016

This rewrite should also improve the isolation of the front end with a view to extracting it into a small JS library that would facilitate possible back-end expansion (see #171, #172). This should also at least partially obsolete #64.

Goals:

  • improve DOM spaghetti
  • clean up front end code so it ages better
    • use Backbone for the Buoy Alert (buoy-alert.js) file
    • use Backbone for the incident view (chat room, etc); requires cleaning up the ugly "templates" thing we have right now
    • use Backbone for the Buoy Map (buoy-map.js) file, where it makes sense
  • leverage some backbone features I've already forgotten the specifics about
  • somehow this is good for the mobile app too I think

Scope:

  • UI shell
  • alerts
  • chat UI
  • does not include maps JS (right?)
  • all new JS should have JS Docs
@hurtstotouchfire
Copy link
Contributor Author

hurtstotouchfire commented Nov 25, 2016

please edit this. I can't remember everything we discussed.

@hurtstotouchfire hurtstotouchfire modified the milestone: Rough beta / solid alpha Nov 25, 2016
@fabacab
Copy link
Contributor

fabacab commented Nov 25, 2016

CC'ing @mcverter, who's expressed an interest in helping with this process, too.

@fabacab
Copy link
Contributor

fabacab commented Dec 2, 2016

@hurtstotouchfire Have a look at #190, which is a PR for the first line item here (which I'm marking "done") because it "improves DOM spaghetti." All I've done is DRY the references to containment-level HTML ids and class attributes.

If more, what else does "improve DOM spaghetti" actually mean?

@mcverter
Copy link
Contributor

mcverter commented Dec 2, 2016 via email

@mcverter
Copy link
Contributor

mcverter commented Dec 2, 2016 via email

@fabacab
Copy link
Contributor

fabacab commented Dec 2, 2016

@mcverter Look at #190.

@mcverter
Copy link
Contributor

mcverter commented Dec 2, 2016 via email

@fabacab
Copy link
Contributor

fabacab commented Dec 13, 2016

Now that #204 is merged I think our next step with the Backbone stuff is to look at the remaining .js files and do the same sort of conversion that we applied to the file in that change set.

I've updated the todo list in this issue to reflect that.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants