This repository has been archived by the owner on Feb 2, 2022. It is now read-only.
WIP: Prepare Buoy front-end modularization by DRY'ing DOM manipulation. #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because JavaScript is a fucking mess, and this also DRYs the front-end testing, Karma will always report failure when running JS tests since the new global JavaScript object to hold the DOM hooks (`buoy_dom_hooks`) isn't being loaded in the test runner's container. Since this object is now dynamically constructed by using WordPress's `wp_localize_script()`, I don't actually know how to include this in the test runner. So, it'd be nice if we figured that out at some point. Meanwhile, we can either: * Repeat ourselves in the test runner and just *hope* things work. * DRY the tests and manually duplicate a JS object in the test runner. I hate both of these options so basically my approach right now is: fuck JavaScript, and fuck these tests, since we're not actually failing builds with the JS tests in Travis (yet) anyway. shrug.gif and stuff.
7 tasks
|
This has been obsoleted by #204. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a big problem with this right now in that it will always break the JavaScript tests. See 43477cb for a frustrated commit message and this chat log for a frustrated request for help in the Better Angels Buoy chat room.
This is a work in progress, expect it to change.