This repository has been archived by the owner on Feb 2, 2022. It is now read-only.
Beginning Backbone Implementation #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dlers from buoy.js. added dependencies in php
|
Please test this and let me know if you require further changes. The code is sound, as far as I can tell |
|
I have some errors still. Sorry about this. Will fix this up asap |
|
Thanks so much for your time on this, @mcverter. I'm merging this as a squashed commit because there are a lot of commits in this but they all represent one logical chunk of work. |
fabacab
added a commit
to fabacab/buoy
that referenced
this pull request
Dec 12, 2016
This reverts commit e4d2047.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started Backbone Implementation.
There are still a few areas that can be optimized.
Changes:
buoy-alert.js ==> replaced most of the jQuery with Backbone objects
buoy.js ==> removed reference to "attachHandlers"
class-buoy-alert.php ==> added javascript dependencies (underscore, jquery, backbone)