You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I also received this error from the ble.recon bettercap module.
Fixes: I am not familiar with the bluetooth spec, so I am not sure if such a length is valid. Nor am I sure what device was causing the error.
If this is not standard and should not be allowed, then adding a check and returning an error would solve the problem. Otherwise, l, t := uint(b[0]), b[1] prevents the overflow.
The text was updated successfully, but these errors were encountered:
How to reproduce: Run the
discoverer.go
example, and have some BLE device nearby that has a 255 byte-long advertisement data, so thatgatt/adv.go
Lines 2008 to 2013 in df6e615
causes
1 + l
to overflow to 0.I also received this error from the
ble.recon
bettercap module.Fixes: I am not familiar with the bluetooth spec, so I am not sure if such a length is valid. Nor am I sure what device was causing the error.
If this is not standard and should not be allowed, then adding a check and returning an error would solve the problem. Otherwise,
l, t := uint(b[0]), b[1]
prevents the overflow.The text was updated successfully, but these errors were encountered: