Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MeshletMesh not writing to the depth prepass #13813

Closed
JMS55 opened this issue Jun 11, 2024 · 0 comments · Fixed by #13816
Closed

MeshletMesh not writing to the depth prepass #13813

JMS55 opened this issue Jun 11, 2024 · 0 comments · Fixed by #13816
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior
Milestone
0.14

Comments

@JMS55
Copy link
Contributor

JMS55 commented Jun 11, 2024 •
edited
Loading

Bevy d659a1f7d506c5c6eba9dfe2a6e878a8c72ecef6.

Since we're binding the material depth as the depth buffer during the meshlet prepass material shading (same for deferred probably), we never write to the prepass depth texture.

We should do a texture copy in the meshlet prepass/deferred node from the view depth to the prepass depth.

EDIT: This issue is wrong, the way the depth prepass is setup means it'll work out. The linked PR fixes an unrelated bug that made it seem like this was the issue.
@JMS55 JMS55 added C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled A-Rendering Drawing game state to the screen and removed S-Needs-Triage This issue needs to be labelled labels Jun 11, 2024
@JMS55 JMS55 added this to the 0.14 milestone Jun 11, 2024
@JMS55 JMS55 mentioned this issue Jun 11, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jun 21, 2024
@JMS55
Fix meshlet interactions with regular shading passes (#13816)
158ccc6 
* Fixes #13813
* Fixes #13810

Tested a combined scene with both regular meshes and meshlet meshes
with:
* Regular forward setup
* Forward + normal/motion vector prepasses
* Deferred (with depth prepass since that's required) 
* Deferred + depth/normal/motion vector prepasses

Still broken:
* Using meshlet meshes rendering in deferred and regular meshes
rendering in forward + depth/normal prepass. I don't know how to fix
this at the moment, so for now I've just add instructions to not mix
them.
mockersf pushed a commit that referenced this issue Jun 21, 2024
@JMS55 @mockersf
Fix meshlet interactions with regular shading passes (#13816)
b56a693 
* Fixes #13813
* Fixes #13810

Tested a combined scene with both regular meshes and meshlet meshes
with:
* Regular forward setup
* Forward + normal/motion vector prepasses
* Deferred (with depth prepass since that's required) 
* Deferred + depth/normal/motion vector prepasses

Still broken:
* Using meshlet meshes rendering in deferred and regular meshes
rendering in forward + depth/normal prepass. I don't know how to fix
this at the moment, so for now I've just add instructions to not mix
them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior
Projects
None yet
Milestone
0.14
Development

Successfully merging a pull request may close this issue.

Fix meshlet interactions with regular shading passes JMS55/bevy
1 participant
@JMS55