Fix meshlet interactions with regular shading passes #13816
Conversation
JMS55
added
C-Bug
alice-i-cecile
added
the
S-Waiting-on-Author
JMS55
removed
the
S-Waiting-on-Author
JMS55
added
the
S-Waiting-on-Author
JMS55
changed the title
JMS55
removed
the
S-Waiting-on-Author
| @@ -162,7 +162,7 @@ impl ViewNode for PrepassNode { | |||
| pass_span.end(&mut render_pass); | |||
| drop(render_pass); | |||
|
|
|||
| // Copy prepass depth to the main depth texture if deferred isn't going to | |||
| // After rendering to the view depth texture, copy it to the prepass depth texture if deferred isn't going to | |||
There was a problem hiding this comment.
The comment makes sense for what the code does, but I'm not sure I understand when that would ever happen. If you use deferred + prepass, then you're using deferred so it will do the copy. If you just use the prepass without deferred, it should run before the main pass so I don't get why we would want to copy the view depth to the prepass depth. Shouldn't it be the other way around?
There was a problem hiding this comment.
Oh, is it because the meshlet prepass writes directly to the view depth?
There was a problem hiding this comment.
I think meshlets should be mentioned in that comment if that's the case.
There was a problem hiding this comment.
This is existing code, for the regular (non meshlet) prepass. We don't actually render directly to the prepass texture, we render to the view depth, and then copy the result into the prepass depth texture.
I was just updating the comment as it was inaccurate before.
There was a problem hiding this comment.
Oh, right, I remember now.
IceSentry
added
the
S-Needs-Review
| @@ -122,17 +122,17 @@ impl ViewNode for DeferredGBufferPrepassNode { | |||
| let view_entity = graph.view_entity(); | |||
| render_context.add_command_buffer_generation_task(move |render_device| { | |||
| #[cfg(feature = "trace")] | |||
| let _deferred_span = info_span!("deferred").entered(); | |||
| let _deferred_span = info_span!("deferred_prepass").entered(); | |||
There was a problem hiding this comment.
Why the rename to add _prepass everywhere?
There was a problem hiding this comment.
It was a bit confusing seeing "deferred" in the profiler. This made it a bit clearer, and matched the node name.
JMS55
added
S-Ready-For-Final-Review
* Fixes #13813 * Fixes #13810 Tested a combined scene with both regular meshes and meshlet meshes with: * Regular forward setup * Forward + normal/motion vector prepasses * Deferred (with depth prepass since that's required) * Deferred + depth/normal/motion vector prepasses Still broken: * Using meshlet meshes rendering in deferred and regular meshes rendering in forward + depth/normal prepass. I don't know how to fix this at the moment, so for now I've just add instructions to not mix them.
Tested a combined scene with both regular meshes and meshlet meshes with:
Still broken: