Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smaller TAA fixes #10200

Merged
merged 9 commits into from
Oct 27, 2023
Merged

Smaller TAA fixes #10200

merged 9 commits into from
Oct 27, 2023

Conversation

JMS55
Copy link
Contributor

@JMS55 JMS55 commented Oct 20, 2023 •
edited by alice-i-cecile

Extracted the easy stuff from #8974 .

Problem

  1. Commands from update_previous_view_projections would crash when matching entities were despawned.
  2. TaaPipelineId and draw_3d_graph module were not public.
  3. When the motion vectors pointed to pixels that are now off screen, a smearing artifact could occur.

Solution

  1. Use try_insert command instead.
  2. Make them public, renaming to TemporalAntiAliasPipelineId.
  3. Check for this case, and ignore history for pixels that are off-screen.

@JMS55 JMS55 added this to the 0.12 milestone Oct 20, 2023
@JMS55 JMS55 added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen labels Oct 20, 2023
alice-i-cecile
alice-i-cecile reviewed Oct 20, 2023
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit one: strongly in favor of.

Commit two: not clear on the motivation of this.

Commit three: a before/after screenshot would be really helpful.

@Diddykonga
Copy link

Nitpick, but enlarging of names should be discouraged unless it is an new/bespoke concept or term, where as TAA is an industry standard and can be found with a simple google search if someone doesn't know what it stands for.

coreh
coreh approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@coreh coreh left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

If we do end up renaming things, do we also need a migration guide section? Or does this not apply because of experimental?

@alice-i-cecile
Copy link
Member

If we do end up renaming things, do we also need a migration guide section? Or does this not apply because of experimental?

The only renames are currently internal, so it's not a breaking change :)

@DGriffin91
Copy link
Contributor

I won't have time to test this later this week so I'm testing it now given that it already has an approval and is on the milestone.

This PR does not fix the edge smearing issue:
taa_screenshot-0

@JMS55
Copy link
Contributor Author

JMS55 commented Oct 24, 2023 •
edited

@DGriffin91 thanks for the test! Should be fixed now. The approach I was using before doesn't work with the way TAA is currently setup, so when I pulled it out of the larger changes it wasn't working.

@rparrett
Copy link
Contributor

Tested with the example from #10200 and the obvious edge blurring is no longer present. Can't really comment beyond that.

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Oct 27, 2023
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Oct 27, 2023
Merged via the queue into bevyengine:main with commit b208388 Oct 27, 2023
22 checks passed
@JMS55 JMS55 mentioned this pull request Oct 28, 2023
Closed
ameknite pushed a commit to ameknite/bevy that referenced this pull request Nov 6, 2023
@JMS55 @ameknite
Smaller TAA fixes (bevyengine#10200)
f0153ca 
Extracted the easy stuff from bevyengine#8974 .

# Problem
1. Commands from `update_previous_view_projections` would crash when
matching entities were despawned.
2. `TaaPipelineId` and `draw_3d_graph` module were not public.
3. When the motion vectors pointed to pixels that are now off screen, a
smearing artifact could occur.

# Solution
1. Use `try_insert` command instead.
2. Make them public, renaming to `TemporalAntiAliasPipelineId`.
3. Check for this case, and ignore history for pixels that are
off-screen.
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this pull request Jan 9, 2024
@JMS55
Smaller TAA fixes (bevyengine#10200)
9152e64 
Extracted the easy stuff from bevyengine#8974 .

# Problem
1. Commands from `update_previous_view_projections` would crash when
matching entities were despawned.
2. `TaaPipelineId` and `draw_3d_graph` module were not public.
3. When the motion vectors pointed to pixels that are now off screen, a
smearing artifact could occur.

# Solution
1. Use `try_insert` command instead.
2. Make them public, renaming to `TemporalAntiAliasPipelineId`.
3. Check for this case, and ignore history for pixels that are
off-screen.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile left review comments

@coreh coreh coreh approved these changes

@atlv24 atlv24 atlv24 approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.12
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@JMS55 @Diddykonga @alice-i-cecile @DGriffin91 @rparrett @coreh @atlv24