Export tonemapping_pipeline_key (2d), alpha_mode_pipeline_key #11166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This expands upon bevyengine#11134
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
mockersf
added
A-Rendering
mockersf
approved these changes
Jan 1, 2024
matiqo15
approved these changes
Jan 1, 2024
matiqo15
added
the
S-Ready-For-Final-Review
JMS55
approved these changes
Jan 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This expands upon #11134.
I found myself needing
tonemapping_pipeline_keyfor some custom 2d draw functions. #11134 exported the 3d version oftonemapping_pipeline_keyand this PR exports the 2d version. I also madealpha_mode_pipeline_keypublic for good measure.