Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added visibility bitmask as an alternative SSAO method #13454

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

dragostis
Copy link

@dragostis dragostis commented May 21, 2024

Early implementation. I still have to fix the documentation and consider writing a small migration guide.

Questions left to answer:

  • should thickness be an overridable constant?
  • is there a better way to implement Eq/Hash for SSAOMethod?
  • do we want to keep the linear sampler for the depth texture?
  • is there a better way to separate the logic than preprocessor macros?

vbao

Copy link
Contributor

Welcome, new contributor!

Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨

@alice-i-cecile alice-i-cecile added C-Enhancement A new feature A-Rendering Drawing game state to the screen S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged labels May 21, 2024
@dragostis dragostis changed the title Added visibility bitmass as an alternative SSAO method Added visibility bitmask as an alternative SSAO method May 21, 2024
@JMS55 JMS55 added this to the 0.15 milestone May 21, 2024
@JMS55 JMS55 requested a review from Elabajaba May 21, 2024 17:08
@JMS55
Copy link
Contributor

JMS55 commented May 21, 2024

@dragostis
Copy link
Author

I added a few questions to answer before merging this and also added a linear sampler for the depth texture since I noticed it slightly improves some of the ghosting noticeable in small objects that happens due to the low resolution mip that gets selected for far-away samples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen C-Enhancement A new feature S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants