improve texture slicing; support non-symmetrical slicing #13488
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
alice-i-cecile
added
C-Feature
|
Assuming this was closed because #13921 fixed the issue? |
|
Yes. |
|
Cool, thanks. Sorry this one seemingly got lost. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Previously, it was impossible to use a texture slicer when the 'center' was not in the exact center of the source image. This PR aims to fix that.
Solution
Changed the slicing algorithm to allow for non-symmetrical slicing.
Code cleanup.
Adjusted the relevant example to show that it's possible.
Fixed some bugs.
Before:
After:
Testing
I tested these changes using the ui_texture_slice example. As far as my testing goes, it works as intended, but it is possible I missed some weird edge case.
Changelog
Changed the texture slicing algorithm.
Changed the ui_texture_slice example.
Added panel-border-020.png asset to showcase the changes.