Implement Clone for CombinatorSystem
#8826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
Where `A, B: Clone`. Needed in order to use chained conditions with `distributive_run_if`.
yyogo
force-pushed
the
cloneable_combinators
branch
from
fc93687
to
f3fc87e
Compare
james7132
added
A-ECS
james7132
approved these changes
Jun 12, 2023
alice-i-cecile
approved these changes
Jun 12, 2023
alice-i-cecile
added
the
S-Ready-For-Final-Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Make a combined system cloneable if both systems are cloneable on their own. This is necessary for using chained conditions (e.g
cond1.and_then(cond2)) withdistributive_run_if().Solution
Implement
CloneforCombinatorSystem<Func, A, B>whereA, B: Clone.