Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Database from Dockerfile #144

Closed
MagicRB opened this issue Oct 8, 2020 · 2 comments
Closed

Remove Database from Dockerfile #144

MagicRB opened this issue Oct 8, 2020 · 2 comments
Labels

Comments

@MagicRB
Copy link

MagicRB commented Oct 8, 2020

It is recommended that unless absolutely necessary a Dockerfile should only run one service. Also with the current configuration, the persistence of the data store is really cumbersome. I will write a new Dockerfile if you're interested in this change

@bfabiszewski
Copy link
Owner

Thanks for the comment.
The docker included in the project is designed only for integration tests. That's why I made a minimal setup that should be small and run fast. It is not suitable for production.
It would be nice to have a production docker that users could use to run the application. It could be separate from this repo. If you create such a docker I will link to it from the Readme. You may consider integrating this pull request.

@stale
Copy link

stale bot commented Dec 12, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants