Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Cluster radii code duplication #49

Closed
bfonta opened this issue Oct 10, 2023 · 1 comment
Closed

[Feature Request] Cluster radii code duplication #49

bfonta opened this issue Oct 10, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@bfonta
Copy link
Collaborator

bfonta commented Oct 10, 2023

A new PR is needed for the following, discussed in the last resolved comment of #47.

(...) involve merging my [@mchiusi] run_radii_chain and @isehle run_cluster_size scripts to use the run_default_chain and run_new_chain. It's not a trivial task because the current code in these latter scripts doesn't allow running the clustering step multiple times. While I don't think it's difficult, I would prefer to open a new PR and address these code repetitions. After making these modifications, we should also test all the chains independently from the webApp. What do you think? (...)

Is your feature request related to a problem? Please describe.
Merging duplicate code.

Describe the solution you'd like and (optionally) propose some code to make it happen
@mchiusi @isehle

Describe alternatives you've considered
@mchiusi @isehle

@bfonta bfonta added the enhancement New feature or request label Oct 10, 2023
@bfonta
Copy link
Collaborator Author

bfonta commented Oct 13, 2023

Issue duplicated in #50.

@bfonta bfonta closed this as completed Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants