You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I plan to reduce this number of files, keeping only the first three from the list. Indeed, for instance, run_radii_chain.py script sequentially calls default and new chain, thus resulting in an unusual code-repetition.
This work will involve merging run_radii_chain and run_cluster_size scripts into run_default_chain and run_new_chain. It's not a trivial task because the current code in these latter scripts doesn't allow running the clustering step multiple times with different clustering parameters. We will have to open a new PR to address these changes.
Additional context
After making these modifications, we should also test all the chains independently and through the webApp.
I have identified an issue in the code I merged in PR New reconstruction chain in the webApp #47 when running pions. Indeed it may happens that the CS is not found for pions, resulting in an incomplete .hdf5 file and thus a webApp error. I have already solved this problem in my own fork and we can merge it here soon. The new working version of the application has been deployed online.
I would suggest to make a unique PR, since the modification to solve the issue above already involved run_radii_chain.py script
If you have any suggestions please write them here or we can discuss them in person next week when I'll back at LLR.
The text was updated successfully, but these errors were encountered:
At the moment in the
scripts
folder there are the following files:I plan to reduce this number of files, keeping only the first three from the list. Indeed, for instance,
run_radii_chain.py
script sequentially calls default and new chain, thus resulting in an unusual code-repetition.This work will involve merging
run_radii_chain
andrun_cluster_size
scripts intorun_default_chain
andrun_new_chain
. It's not a trivial task because the current code in these latter scripts doesn't allow running the clustering step multiple times with different clustering parameters. We will have to open a new PR to address these changes.Additional context
.hdf5
file and thus a webApp error. I have already solved this problem in my own fork and we can merge it here soon. The new working version of the application has been deployed online.I would suggest to make a unique PR, since the modification to solve the issue above already involved
run_radii_chain.py
scriptIf you have any suggestions please write them here or we can discuss them in person next week when I'll back at LLR.
The text was updated successfully, but these errors were encountered: