Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reducing the number of scripts for running reco chains #50

Open
mchiusi opened this issue Oct 13, 2023 · 0 comments
Open

Reducing the number of scripts for running reco chains #50

mchiusi opened this issue Oct 13, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@mchiusi
Copy link
Collaborator

mchiusi commented Oct 13, 2023

At the moment in the scripts folder there are the following files:

I plan to reduce this number of files, keeping only the first three from the list. Indeed, for instance, run_radii_chain.py script sequentially calls default and new chain, thus resulting in an unusual code-repetition.

This work will involve merging run_radii_chain and run_cluster_size scripts into run_default_chain and run_new_chain. It's not a trivial task because the current code in these latter scripts doesn't allow running the clustering step multiple times with different clustering parameters. We will have to open a new PR to address these changes.

Additional context

  • After making these modifications, we should also test all the chains independently and through the webApp.
  • I have identified an issue in the code I merged in PR New reconstruction chain in the webApp #47 when running pions. Indeed it may happens that the CS is not found for pions, resulting in an incomplete .hdf5 file and thus a webApp error. I have already solved this problem in my own fork and we can merge it here soon. The new working version of the application has been deployed online.
    I would suggest to make a unique PR, since the modification to solve the issue above already involved run_radii_chain.py script

If you have any suggestions please write them here or we can discuss them in person next week when I'll back at LLR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant