Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix trigger cell positions (detected due to wrong orientation of partial wafers, see picture below).
Each wafer is created separately (a group of up to 48 trigger cells), and is later shifted to occupy the correct position in the endcap. The geometry was wrongly using a mirrored wafer shift, meaning that wafers on the left would end up on the right, and vice-versa. This explained the inverted placement of all partials in the boundaries, which could not be fixed by any rotation of single wafers.
Geometry after the fix shown below:
This PR also includes code rewrite regarding the geometry class, most importantly including the preparation of the dataframe for display directly in the class.