stdlib necessary?

[jangrewe]

Hi, we're tried to using your module as-is, but we have a duplicate declaration of 'stdlib' because we're using it for stages - but i didn't notice any usage of stdlib in your module?
Is it possible to remove it from your init manifest? If so, i'd open a pull request, as we've also added the default_route parameter.

thanks,
Jan

[bfraser]

Hi, thanks for your interest in the module.

Yes, stdlib is being used for the empty() function in init.pp to check that the datasources hash is not empty. We should likely be using validate_hash(), but this would still require stdlib.

[jangrewe]

I've looked at some of the other forks, and removing the stdlib isn't too uncommon among them. I don't have any hard evidence, but i'm guessing that most people include stdlib in a more commong location then just one particular module...
I'm not saying you should remove the stdlib functions you're using, i'm just asking if it may be possible to remove the include in your module! ;-)

[bfraser]

Hi @jangrewe you are correct, this module does not make use of stages, so the inclusion of stdlib is unnecessary. I have just pushed a commit which removes it.

Please feel free to submit a pull request to parameterize the default_route setting. Thanks!