-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stdlib necessary? #9
Comments
Hi, thanks for your interest in the module. Yes, stdlib is being used for the empty() function in init.pp to check that the datasources hash is not empty. We should likely be using validate_hash(), but this would still require stdlib. |
I've looked at some of the other forks, and removing the stdlib isn't too uncommon among them. I don't have any hard evidence, but i'm guessing that most people include stdlib in a more commong location then just one particular module... |
Hi @jangrewe you are correct, this module does not make use of stages, so the inclusion of stdlib is unnecessary. I have just pushed a commit which removes it. Please feel free to submit a pull request to parameterize the default_route setting. Thanks! |
* fix rubocop errors
* fix rubocop errors
Hi, we're tried to using your module as-is, but we have a duplicate declaration of 'stdlib' because we're using it for stages - but i didn't notice any usage of stdlib in your module?
Is it possible to remove it from your init manifest? If so, i'd open a pull request, as we've also added the default_route parameter.
thanks,
Jan
The text was updated successfully, but these errors were encountered: