Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possibe timeout issue with too many clients. #57

Closed
ibalajiarun opened this issue Apr 3, 2018 · 0 comments
Closed

Possibe timeout issue with too many clients. #57

ibalajiarun opened this issue Apr 3, 2018 · 0 comments

Comments

@ibalajiarun
Copy link

ibalajiarun commented Apr 3, 2018 •
edited
Loading

In RequestTimer.java, I do not think unwatch will ever call stopTimer, if the watched queue is continuously populated. Therefore, the timer will expire even during normal operation, and cause a leader change. Is there some other mechanism that ensures that the timer is reset?

https://github.com/bft-smart/library/blob/master/src/bftsmart/tom/leaderchange/RequestsTimer.java#L128
@jcs47 jcs47 closed this as completed Sep 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ibalajiarun @jcs47