fix: improve fuzzing #449
Merged
fix: improve fuzzing #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
📊 Package size report No changes
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
sakulstra
commented
May 15, 2024
| @@ -1,7 +1,11 @@ | |||
| export type Address = { | |||
| export type SearchItem = { | |||
There was a problem hiding this comment.
renamed as i found it super confusing (given Address is 0xstring in viem)
| threshold: 0.2, | ||
| ignoreLocation: true, | ||
| // ignoreLocation: false, |
There was a problem hiding this comment.
not ignoring location rates lib.oracle > lib.asset.oracle which is what we want.
| import Fuse, { FuseResult } from 'fuse.js'; | ||
| import { Box } from './Box'; | ||
| import { SearchResult } from './SearchResult'; | ||
|
|
||
| const fuseOptions = { | ||
| includeScore: true, | ||
| keys: ['searchPath', 'value'], | ||
| keys: ['searchPath', 'value', 'library', 'key'], |
There was a problem hiding this comment.
adding the root (library) and the end (key) as dedicated results makes the behavior more natural as in this case locationSearch will no longer consider the distance (given oracle would exact match the key)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.