Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the Docker Hub container thingy #19

Closed
randomthingsandstuff opened this issue Aug 17, 2021 · 7 comments
Closed

Fix the Docker Hub container thingy #19

randomthingsandstuff opened this issue Aug 17, 2021 · 7 comments
Labels
easy-stuff Something that takes less than 2 hours to do

Comments

@randomthingsandstuff
Copy link
Contributor

Yeah, its been broken since we forked. I don't have a hub account and should probably think about getting one or something.

I want this done before we release the first (real) version... so let's see if we get it done within 5 versions :D

@ties
Copy link
Collaborator

ties commented Aug 17, 2021

I think we are publishing docker images. What's probably lacking is documenting that + actually tagging releases.

@randomthingsandstuff
Copy link
Contributor Author

Oh nice! so I'll just need to update the docs to use rpki/stayrtr then. I'm guessing @job set this up or something.

@randomthingsandstuff randomthingsandstuff added the easy-stuff Something that takes less than 2 hours to do label Aug 17, 2021
@job
Copy link
Member

job commented Aug 17, 2021

Me and @robert-scheck have access to the Docker Hub account for the rpki org,

We're riding the free tier which permits 3 accounts: 2 humans and 1 robot. The robot is hooked up to this repo.

@lspgn
Copy link
Contributor

lspgn commented Aug 17, 2021

My two cents
In GoFlow2, was able to use API keys and have the docker build inside Actions
https://github.com/netsampler/goflow2/blob/main/.github/workflows/docker-release.yaml

@job
Copy link
Member

job commented Aug 17, 2021

@lspgn we're using the API keys of a robot user called rpkier

@robert-scheck
Copy link

robert-scheck commented Aug 17, 2021

I've performed the Docker Open Source Community Application in the rpki-client context (which might wipe this limit as well), but we are still under evaluation. And rpki-client uses also the GitHub Actions, thus I guess the same might work for stayrtr, too.

@ties
Copy link
Collaborator

ties commented Aug 18, 2021

My two cents
In GoFlow2, was able to use API keys and have the docker build inside Actions
https://github.com/netsampler/goflow2/blob/main/.github/workflows/docker-release.yaml

Nice way of doing the ARM build and doing the releases on tags. Would be good to incorporate this for release tags as well.
(In general I've started to really appreciate GitHub actions)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy-stuff Something that takes less than 2 hours to do
Projects
None yet
Development

No branches or pull requests

5 participants