Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scripted update workflow helper #33

Merged
merged 2 commits into from
Dec 18, 2018
Merged

Conversation

dbast
Copy link
Contributor

@dbast dbast commented Dec 16, 2018

This is the process I often use to update feedstocks.

Just a collection of commands out of my git history combined with some glue code.

I thought it would make sense to share this by including it here.

Any thoughts on how to optimize this or how your process looks like are welcome.

Thanks

@bgruening
Copy link
Owner

Thanks, @dbast! That's really helpful. Please note that conda-forge has a bot that does something similar. The bot is currently a little bit slow as the migration to GCC7 is still ongoing. But in an ideal world we do not need to do this manually.

Thanks a lot!

@bgruening bgruening merged commit 017c1d2 into bgruening:master Dec 18, 2018
@dbast
Copy link
Contributor Author

dbast commented Dec 18, 2018

Thanks, yes, I know that the bot is doing the updates. I found it quite helpful to get a full diff between an existing recipe and a new skeleton run to even update parts of the recipe which the bot does not touch.

@jdblischak
Copy link
Collaborator

I found it quite helpful to get a full diff between an existing recipe and a new skeleton run to even update parts of the recipe which the bot does not touch.

@dbast Thanks for sharing your solution! I agree it can be tedious to check the bot's update, especially for packages with lots of dependencies with minimum version requirements.

What operating system(s) have you tested this script on? Any reason to supsect it wouldn't work identically on Linux and macOS?

@dbast
Copy link
Contributor Author

dbast commented Dec 18, 2018

@jdblischak The script was fully developed and tested on macOS.

It is shellcheck clean and should run in any bash on Linux/macOS.

Maybe the read -n1 is not optimal, because if you answer one of the questions with y + enter instead of y only, read will only take the y and the next question is answered with just enter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants