Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tool downloads are not working #50

Closed
bgruening opened this issue Mar 26, 2015 · 1 comment
Closed

Tool downloads are not working #50

bgruening opened this issue Mar 26, 2015 · 1 comment

Comments

@bgruening
Copy link
Owner

From Kyle:

Trying to use the tool download function, ie /api/tools/tool_name/download
and I get a 404.

Example:

curl http://128.114.61.142:9999/api/tools/MuSE/download?key=admin
<html>
<head><title>404 Not Found</title></head>
<body bgcolor="white">
<center><h1>404 Not Found</h1></center>
<hr><center>nginx/1.4.6 (Ubuntu)</center>
</body>
</html>

The Galaxy log does just fine:

[pid: 158|app: 0|req: 295/295] 76.126.58.122 () {32 vars in 420 bytes} [Thu Mar 26 06:45:50 2015] GET /api/tools/MuSE/download?key=admin => generated 0 bytes in 15 msecs (HTTP/1.1 200) 5 headers in 269 bytes (1 switches on core 2)
@bgruening
Copy link
Owner Author

My guess is that we need to add this download location to nginx, will try this later today.

jmchilton added a commit to jmchilton/galaxy that referenced this issue Mar 26, 2015
@jmchilton
Fix proxied API tool downloads.
a1bb898 
From IRC:

17:22 < kellrott> Any ideas about how to deal with bgruening/docker-galaxy-stable#50 ?
17:22 < mrscribe> Title: Tool downloads are not working · Issue #50 · bgruening/docker-galaxy-stable · GitHub (at
                  github.com)
17:24 < kellrott> I think its from how the tool download function unlinks a file while holding the open file handle
                  ( https://github.com/galaxyproject/galaxy/blob/dev/lib/galaxy/webapps/galaxy/api/tools.py#L208 )
17:24 < mrscribe> Title: galaxy/tools.py at dev · galaxyproject/galaxy · GitHub (at github.com)
17:27 < jmchilton> Have you tried not unlinking that file?
17:28 < jmchilton> If that fixes it I have no problem just leaving the file in temp - Galaxy leaves a lot of stuff
                   in temp anyway
17:46 < kellrott> yep, that does the trick

Closes bgruening/docker-galaxy-stable#50.
@jmchilton jmchilton mentioned this issue Mar 26, 2015
Merged
bebatut pushed a commit to bebatut/docker-galaxy-stable that referenced this issue Apr 11, 2017
@bgruening
Merge pull request bgruening#50 from yhoogstrate/flaimapper
37e93ef 
Add FlaiMapper to tools list
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bgruening