Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace SCRIPT_PATH with $__tool_directory__ #101

Merged
merged 1 commit into from
Apr 16, 2015
Merged

Replace SCRIPT_PATH with $__tool_directory__ #101

merged 1 commit into from
Apr 16, 2015

Conversation

bgruening
Copy link
Owner

This will fix #85

bgruening added a commit that referenced this pull request Apr 16, 2015
@bgruening
Merge pull request #101 from bgruening/kill_script_path
dd23c9d 
Replace SCRIPT_PATH with `$__tool_directory__`
@bgruening bgruening merged commit dd23c9d into master Apr 16, 2015
@bgruening bgruening deleted the kill_script_path branch April 16, 2015 13:47
@nsoranzo
Copy link
Collaborator

I think you forgot to remove CRISPR_RECOGNITION_TOOL_SCRIPT_PATH set_to action in galaxytools/tools/crt/tool_dependencies.xml .

@bgruening
Copy link
Owner Author

@nsoranzo hah, thanks! Your review skills are impressive!
@jmchilton is this a devil?

@jmchilton
Copy link
Collaborator

"smiling imp" - I thought the emoji might convey the intention better than mwahahaha.

Also - yes @nsoranzo is amazing - we need to somehow create a command-line version of him so we can apply these checks before committing.

@bgruening
Copy link
Owner Author

👍 :)

@nsoranzo
Copy link
Collaborator

😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace *_SCRIPT_PATH with $__tool_directory__
3 participants
@bgruening @nsoranzo @jmchilton