credis_connect() calls gethostbyname(), which is not reentrant

[GoogleCodeExporter]

Line 715 in credis_connect() calls gethostbyname() which is not reentrant.  
gethostbyname_r() is reentrant.  Also note that both of the gethostbyname() 
calls are deprecated, replaced with getnameinfo().

Original issue reported on code.google.com by deanwba...@gmail.com on 15 Sep 2010 at 12:00

[GoogleCodeExporter]

I can take a stab at a patch later in the week if it helps.

Cheers.

Original comment by deanwba...@gmail.com on 15 Sep 2010 at 12:18

[GoogleCodeExporter]

Ooops I missed that lots of people ask me if credis is thread safe and I've 
told them yes, it should be... I reused an old snippet when starting on Credis 
so I will gladly accept a patch that fixes this issue.

cheers, 
Jonas

Original comment by romf...@gmail.com on 15 Sep 2010 at 7:41

• Changed state: Accepted

[GoogleCodeExporter]

Question--

gethostbyname() is only called in the event that inet_aton(host, &sa.sin_addr) 
fails.  On my system, it doesn't fail, so I haven't had any issues with thread 
safety.  My question is:  When would inet_aton fail that gethostbyname() would 
succeed?

Cheers,

Dean

Original comment by deanwba...@gmail.com on 15 Sep 2010 at 9:58

[GoogleCodeExporter]

This should do it for the non-Win build.  I did not check the Win side, but I 
don't think I broke anything.  Shout if I messed up--still learning the ropes...

Cheers,

Dean

Original comment by deanwba...@gmail.com on 18 Sep 2010 at 1:14

Attachments:

• getaddrinfo.patch

[GoogleCodeExporter]

thanks, I have taken your patch with minor changes

Original comment by romf...@gmail.com on 21 Sep 2010 at 12:34

[GoogleCodeExporter]

Original comment by romf...@gmail.com on 21 Sep 2010 at 12:34

• Changed state: Fixed