Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For function specs, show which spec failed. #13

Closed
jeaye opened this issue Aug 9, 2017 · 9 comments
Closed

For function specs, show which spec failed. #13

jeaye opened this issue Aug 9, 2017 · 9 comments

Comments

@jeaye
Copy link

jeaye commented Aug 9, 2017

When instrumenting, especially with orchestra, expound provides less information than clojure.spec would, since it doesn't say whether or not it was the :ret or :args or :fn that failed to validate.

Are you open to adding this support?

@bhb
Copy link
Owner

bhb commented Aug 9, 2017

@jeaye You read my mind 😄. This is something I hope to complete sometime this week.

I'm not 100% sure yet how to format the error, but it's something I want to support. Would you mind giving me feedback when I have a draft version?

@jeaye
Copy link
Author

jeaye commented Aug 9, 2017

Sure thing; let me know when you have a snapshot version, or branch or whatever you prefer, and I'll give it a shot. Thanks for the quick reply!

@bhb
Copy link
Owner

bhb commented Aug 10, 2017

I still need to do some more dogfooding on this, but I have something you can try when you have some time:

  1. git clone git@github.com:bhb/expound.git
  2. cd expound
  3. git co support-orchestra
  4. lein install
  5. In your test project, include [expound "0.1.3-SNAPSHOT"]

The relevant tests are here

@jeaye
Copy link
Author

jeaye commented Aug 10, 2017 via email

@bhb
Copy link
Owner

bhb commented Aug 10, 2017

Excellent, thanks very much for your help!

@jeaye
Copy link
Author

jeaye commented Aug 13, 2017

I've just given this branch a go with our ClojureScript app and have introduced the various :ret, :args, and :fn errors. The new expound output is much more helpful and the docs included in the README look great.

Thank you for the explicit orchestra support; I'm looking into the :via issue now.

@bhb
Copy link
Owner

bhb commented Aug 13, 2017

Glad to hear it! Thanks very much for trying this out. I'll do a release this week.

@bhb bhb closed this as completed Aug 15, 2017
@bhb
Copy link
Owner

bhb commented Aug 15, 2017

I have released version 0.2.0 which includes this feature. Thanks for the help! https://clojars.org/expound/versions/0.2.0

@jeaye
Copy link
Author

jeaye commented Aug 15, 2017

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants