Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expound omits second problem #73

Closed
bhb opened this issue Mar 16, 2018 · 1 comment
Closed

Expound omits second problem #73

bhb opened this issue Mar 16, 2018 · 1 comment
Labels

Comments

@bhb
Copy link
Owner

bhb commented Mar 16, 2018

Compare:

(s/explain
   (:args (s/get-spec `defn))
   `(~'foo (~'arg1 ~'arg2) ~'arg3))

Output is:

In: [1 0] val: arg1 fails spec: :clojure.core.specs.alpha/arg-list at: [:bs :arity-n :bodies :args] predicate: vector?
In: [1] val: (arg1 arg2) fails spec: :clojure.core.specs.alpha/arg-list at: [:bs :arity-1 :args] predicate: vector?

With expound:

(expound/expound
 (:args (s/get-spec `defn))
 `(~'foo (~'arg1 ~'arg2) ~'arg3))

Output (in part)

-- Spec failed --------------------

  (... (arg1 ...) ...)
        ^^^^

should satisfy

  vector?

Note that the more interesting case is omitted - that the parent collection is a list instead of a vector.

@bhb bhb added the bug label Mar 16, 2018
@bhb
Copy link
Owner Author

bhb commented Jun 24, 2018

This is fixed and will be included in the next release. In the meantime, there 0.7.1-SNAPSHOT includes this fix.

cc @carocad @jumarko @AISUMU

@bhb bhb closed this as completed Jun 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant