Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

硕士论文的公式编号应该是 1.1 的格式,而不是 1-1 的格式…… #89

Closed
grissiom opened this issue Nov 30, 2012 · 6 comments
Labels

Comments

@grissiom
Copy link
Member

RT。暂时不知怎么改……

@huxuan
Copy link
Member

huxuan commented Nov 30, 2012

@grissiom hi, wish you can view pull request #91 which seems to fix this bug.
If it's ok, just merge it with 'Fix #89' or something like that!

grissiom added a commit that referenced this issue Nov 30, 2012
@grissiom
Copy link
Member Author

Github doesn't close this issue by analyze the merge commit. So just close it by hand.

@huxuan
Copy link
Member

huxuan commented Nov 30, 2012

Fixed by pull request #91

@huxuan
Copy link
Member

huxuan commented Nov 30, 2012

@grissiom hi, github do can close issue by commit with certain syntax.
When merge pull request you can add msg like 'Fix #89' to auto close this issue
More infomation can be found at https://github.com/blog/831-issues-2-0-the-next-generation
To be more specific, the "Commits + Issues" part.

@grissiom
Copy link
Member Author

@huxuan Yeah, thank you for that useful link. I wrote "fix issue #xx" and it seems that github failed to trigger the closing event.... I think "fix #xx" is ambiguous to the ones who is not familiar to github.

@huxuan
Copy link
Member

huxuan commented Nov 30, 2012

@grissiom As metioned in that post, only six synonyms is supported:

  • fixes #xxx
  • fixed #xxx
  • fix #xxx
  • closes #xxx
  • close #xxx
  • closed #xxx

so I think something like 'Issue Fixed #89' may be a better solution for your concern.
For me, I used to add "fix #XX" as a additional part of commit msg. Just like 394d729.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants