Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upate for PointMass initmarginals and initmasseges #360

Merged
merged 2 commits into from
Nov 1, 2023

Conversation

Chengfeng-Jia
Copy link
Member

For the RxInfer issue.

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (2b76f0f) 66.17% compared to head (e858592) 65.81%.
Report is 204 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #360      +/-   ##
==========================================
- Coverage   66.17%   65.81%   -0.37%     
==========================================
  Files         207      208       +1     
  Lines        7509     7374     -135     
==========================================
- Hits         4969     4853     -116     
+ Misses       2540     2521      -19     
Files Coverage Δ
src/variables/variable.jl 31.94% <0.00%> (-1.39%) ⬇️

... and 81 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bartvanerp bartvanerp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good that we identified the related lines, let's write two small tests and get it merged

Copy link
Member

@bvdmitri bvdmitri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that is the reason, good that you've found it. A small test would suffice.

@Chengfeng-Jia
Copy link
Member Author

Thank @bvdmitri for your previous extensible code, which makes writing a test easier.

@bartvanerp bartvanerp marked this pull request as ready for review October 31, 2023 14:28
@bvdmitri bvdmitri merged commit 6cff9c7 into main Nov 1, 2023
5 of 7 checks passed
@bvdmitri bvdmitri deleted the Fix_PointMass_init branch November 1, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

initmarginals broadcasting not working for PointMass
3 participants