Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bookshelf Manager Wizard's buttons not translated #131

Closed
Merlignux opened this issue Jan 13, 2018 · 2 comments
Closed

Bookshelf Manager Wizard's buttons not translated #131

Merlignux opened this issue Jan 13, 2018 · 2 comments

Comments

@Merlignux
Copy link

@Merlignux Merlignux commented Jan 13, 2018

The new Bookshelf Manager Wizard's buttons are not translated

Next, Cancel and Finish do not get translated in this wizard.

gholmlund added a commit that referenced this issue Jan 16, 2018
…ttons are translated.
gholmlund added a commit that referenced this issue Jan 16, 2018
…ttons are translated.
@gholmlund gholmlund self-assigned this Jan 16, 2018
@gholmlund
Copy link
Contributor

@gholmlund gholmlund commented Jan 16, 2018

The buttons on QWizard cannot be translated by our code. They rely on loading translation files provide by Qt. The code to load the translation files in main.cpp was not correct and is now fixed. However, the translation files are in a package that must be installed. on ubuntu 17.10 this package is qttranslations5-l10n.

@Merlignux
Copy link
Author

@Merlignux Merlignux commented Jan 17, 2018

I hadn't tried it on Linux. On openSUSE (Tumbleweed) translation is just fine... :)

How will this work on Windows? Will a separated package have to be installed as well or will it be fixed/included in a future update?

Anyway, thanks for your help again Gary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.