Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bookshelf Manager Wizard's buttons not translated #131

Closed
Merlignux opened this issue Jan 13, 2018 · 2 comments
Closed

Bookshelf Manager Wizard's buttons not translated #131

Merlignux opened this issue Jan 13, 2018 · 2 comments
Assignees
@gholmlund
Labels
component: Bookshelf Manager component: Qt related resolution: FIXED The issue is fixed. Instructions from comments might have to be followed to resolve this locally. type: BUG
Milestone
2.11.2

Comments

@Merlignux
Copy link

Merlignux commented Jan 13, 2018 •
edited
Loading

The new Bookshelf Manager Wizard's buttons are not translated

Next, Cancel and Finish do not get translated in this wizard.
gholmlund pushed a commit that referenced this issue Jan 16, 2018
Fix bug #131, Add Qt translation file path so the Bookshelf Wizard bu…
6838105 
…ttons are translated.
gholmlund pushed a commit that referenced this issue Jan 16, 2018
Fix bug #131, Add Qt translation file path so the Bookshelf Wizard bu…
4faf7e6 
…ttons are translated.
@gholmlund gholmlund self-assigned this Jan 16, 2018
@gholmlund
Copy link
Contributor

The buttons on QWizard cannot be translated by our code. They rely on loading translation files provide by Qt. The code to load the translation files in main.cpp was not correct and is now fixed. However, the translation files are in a package that must be installed. on ubuntu 17.10 this package is qttranslations5-l10n.

@gholmlund gholmlund added the resolution: FIXED The issue is fixed. Instructions from comments might have to be followed to resolve this locally. label Jan 16, 2018
@Merlignux
Copy link
Author

I hadn't tried it on Linux. On openSUSE (Tumbleweed) translation is just fine... :)

How will this work on Windows? Will a separated package have to be installed as well or will it be fixed/included in a future update?

Anyway, thanks for your help again Gary

@jaakristioja jaakristioja added this to the 2.11.2 milestone Jun 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gholmlund gholmlund

Labels
component: Bookshelf Manager component: Qt related resolution: FIXED The issue is fixed. Instructions from comments might have to be followed to resolve this locally. type: BUG
Milestone
2.11.2
Development

No branches or pull requests
3 participants
@jaakristioja @gholmlund @Merlignux