Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make saveAsXLSX grab current filters before getReportData #253

Closed
wants to merge 2 commits into from
Closed

Make saveAsXLSX grab current filters before getReportData #253

wants to merge 2 commits into from

Conversation

barisdigi
Copy link
Contributor

#252

Should save currently show data as XLSX now

@barisdigi barisdigi marked this pull request as draft September 30, 2020 18:29
@barisdigi barisdigi mentioned this pull request Sep 30, 2020
Closed
@jajm
Copy link
Member

jajm commented Oct 1, 2020

This works well, and code is clean. Thanks! :)
Tests would be really appreciated, but as the reports-view controller is not tested at all, it's okay if you don't write them. Feel free to remove the "draft" status if you want me to merge this pull request.

@jajm
Copy link
Member

jajm commented Aug 16, 2021

Merged manually

@jajm jajm closed this Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@barisdigi @jajm