Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report filters don't apply to xlsx exports #252

Closed
barisdigi opened this issue Sep 23, 2020 · 2 comments
Closed

Report filters don't apply to xlsx exports #252

barisdigi opened this issue Sep 23, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@barisdigi
Copy link
Contributor

barisdigi commented Sep 23, 2020

Describe the bug
When a filter is applied to a report, the changes can be seen on the report screen but when exporting to xlsx, the filters don't apply.

To Reproduce
Steps to reproduce the behavior:

  1. Open a report that will produce 0 results with default filters
  2. Apply filters that will produce results
  3. Export xlsx
  4. See that the file is empty

Expected behavior
The export should happen with current files

Server (please complete the following information):

  • OS: Docker Compose on Ubuntu 18.04
  • MongoDB: 4.2.6
  • Datasource(s): MySQL

Client (please complete the following information):

  • OS: Windows 10
  • Browser Chrome 85.0.4183.102
    Additional context
    I've tried various filters, it does not seem to depend on the filter used. I think this will really get in the way of people using urungi.
@barisdigi barisdigi added the bug Something isn't working label Sep 23, 2020
@PaulPoulain
Copy link
Member

Thanks for the report @Quitra01 . Do you plan to provide a fix ? Welcome on board though, I hope you'll enjoy urungi !

@barisdigi
Copy link
Contributor Author

Thank you for the welcome, I had time to check it out today and made a fix with #253. I made it check the current filters before getting the data. I'll probably write some tests for it when I have the time this weekend.

@jajm jajm closed this as completed Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants