Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PHP 8 #48

Closed
S1SYPHOS opened this issue Jan 11, 2022 · 9 comments · Fixed by #67
Closed

Add support for PHP 8 #48

S1SYPHOS opened this issue Jan 11, 2022 · 9 comments · Fixed by #67

Comments

@S1SYPHOS
Copy link
Contributor

Hey there,
since my upgrade to PHP 8 I get this when updating via composer:

biblys/isbn 2.4.0 requires php ^7.1 -> your php version (8.0.8) does not satisfy that requirement.

Please upgrade your composer.json accordingly, see #36

Thanks!

@clemlatz
Copy link
Member

Hey @S1SYPHOS, I don't plan to support before the next major version of this library, because PHP 8.0 support requires to remove deprecated code, but I will try to release a 3.0 beta version as soon as possible.

@S1SYPHOS
Copy link
Contributor Author

Thanks very much for letting me know - in the meantime, I'll go full risk with --ignore-platform-reqs 🦊

@clemlatz
Copy link
Member

You can now install the 3.0 beta version, supporting PHP 8, using the next branch:
https://github.com/biblys/isbn/tree/next

I'll keep this issue open until 3.0 is released and PHP 8 officially supported.

@S1SYPHOS
Copy link
Contributor Author

S1SYPHOS commented Jun 26, 2022

It might be easier to release the next branch as 3.0.0-beta.1 pre-release, though .. this might help mitigate Composer complaining about minimum stability. Could you give an estimate when v3 will be released? Maybe I can help move things along ✌️

// Edit: I just had a look at the 'roadmap' board, I'll see if I can whip up something!

@clemlatz
Copy link
Member

clemlatz commented Jun 26, 2022

Hey @S1SYPHOS, I've just released a 3.0.0-alpha.1 version (as development is still in progress, it's more an alpha than a beta) based on the next branch.

I didn't work a lot on this library for the past few months due to lack of motivation, but I can find some if I know others users are bothered by the current state of the project (I'm still struggling to update to PHP 8 on my main project, hence the lack of motivation).

Please tell me if you have any question about the roadmap (the discussion section should be great for that).

@S1SYPHOS
Copy link
Contributor Author

Today I tried nicebooks/isbn which works very good and has full PHP v8 support 😕

@clemlatz
Copy link
Member

No hurt feelings, if it better suites for your use case, go for it! And thanks again for you contributions 🙂

@ph-il
Copy link

ph-il commented Oct 10, 2022

You can use Rector to move to PHP 8.0 or even 8.1.

@S1SYPHOS
Copy link
Contributor Author

Thanks @ph-il 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Released
Development

Successfully merging a pull request may close this issue.

3 participants