-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Fix MEG datatype for tabular data #1131
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1131 +/- ##
==========================================
+ Coverage 75.20% 75.86% +0.66%
==========================================
Files 11 11
Lines 1359 1359
==========================================
+ Hits 1022 1031 +9
+ Misses 337 328 -9
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the catch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!
Can someone remind me of the process from here (it varies across organisations, I can't keep track). Do I click merge? Or is that something a maintainer will do before version 1.7.1? |
If this was a real content change, we would wait five days to allow any interested folks in the community to comment or raise concerns. However, since it's a straightforward bug fix, I think it's fine to just merge. I'll merge it now. |
Small change I found while preparing the fNIRS BEP