Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Fix MEG datatype for tabular data #1131

Merged
merged 1 commit into from
Jun 29, 2022

Conversation

rob-luke
Copy link
Member

Small change I found while preparing the fNIRS BEP

@rob-luke rob-luke requested a review from tsalo as a code owner June 20, 2022 06:28
@codecov
Copy link

codecov bot commented Jun 20, 2022

Codecov Report

Merging #1131 (18cba69) into master (12236b0) will increase coverage by 0.66%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1131      +/-   ##
==========================================
+ Coverage   75.20%   75.86%   +0.66%     
==========================================
  Files          11       11              
  Lines        1359     1359              
==========================================
+ Hits         1022     1031       +9     
+ Misses        337      328       -9     
Impacted Files Coverage Δ
tools/schemacode/schemacode/_version.py 38.90% <0.00%> (+2.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12236b0...18cba69. Read the comment docs.

Copy link
Member

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the catch!

@sappelhoff sappelhoff added this to the 1.7.1 milestone Jun 22, 2022
Copy link
Member

@tsalo tsalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@rob-luke
Copy link
Member Author

Can someone remind me of the process from here (it varies across organisations, I can't keep track). Do I click merge? Or is that something a maintainer will do before version 1.7.1?

@tsalo
Copy link
Member

tsalo commented Jun 29, 2022

If this was a real content change, we would wait five days to allow any interested folks in the community to comment or raise concerns. However, since it's a straightforward bug fix, I think it's fine to just merge. I'll merge it now.

@tsalo tsalo merged commit 0749755 into bids-standard:master Jun 29, 2022
@rob-luke rob-luke deleted the rob-luke-patch-1 branch June 30, 2022 02:06
TheChymera pushed a commit to TheChymera/bids-specification that referenced this pull request Jul 13, 2022
@effigies effigies added the exclude-from-changelog This item will not feature in the automatically generated changelog label Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude-from-changelog This item will not feature in the automatically generated changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants