Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Apply derivative definition to qMRI appendix #1813

Merged
merged 11 commits into from
Aug 29, 2024

Conversation

Remi-Gau
Copy link
Collaborator

@Remi-Gau Remi-Gau commented May 6, 2024

Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.10%. Comparing base (7b0f76d) to head (39c6cfc).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1813   +/-   ##
=======================================
  Coverage   88.10%   88.10%           
=======================================
  Files          16       16           
  Lines        1396     1396           
=======================================
  Hits         1230     1230           
  Misses        166      166           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/appendices/qmri.md Outdated Show resolved Hide resolved
src/appendices/qmri.md Outdated Show resolved Hide resolved
src/appendices/qmri.md Outdated Show resolved Hide resolved
@Remi-Gau Remi-Gau requested a review from agahkarakuzu May 6, 2024 13:33
src/appendices/qmri.md Outdated Show resolved Hide resolved
src/appendices/qmri.md Outdated Show resolved Hide resolved
src/schema/objects/common_principles.yaml Outdated Show resolved Hide resolved
@Remi-Gau Remi-Gau marked this pull request as ready for review May 6, 2024 13:39
Remi-Gau and others added 5 commits May 6, 2024 15:39
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
@Remi-Gau
Copy link
Collaborator Author

Remi-Gau commented May 7, 2024

Will create a companion PR to modify a couple of bids example to make that the validator has got something to sink its teeth into.

@effigies effigies added this to the 1.10.0 milestone May 25, 2024
@effigies effigies changed the title [ENH] apply derivative definition to qMRI [ENH] Apply derivative definition to qMRI appendices Aug 21, 2024
@effigies effigies changed the title [ENH] Apply derivative definition to qMRI appendices [ENH] Apply derivative definition to qMRI appendix Aug 21, 2024
@Remi-Gau
Copy link
Collaborator Author

@agahkarakuzu can you maybe cross-check what I did here?

src/appendices/qmri.md Outdated Show resolved Hide resolved
src/appendices/qmri.md Outdated Show resolved Hide resolved
@agahkarakuzu
Copy link
Contributor

@Remi-Gau the changes you introduced looks good to me! This was initially what we wanted to do, but at that time it was not really clear. Thank you!

Co-authored-by: Taylor Salo <tsalo90@gmail.com>
@effigies effigies merged commit c9897e1 into bids-standard:master Aug 29, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update qMRI to align with the new definition of derivatives
4 participants