Add Api function to get random tag value add key authentication #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| private | ||
| def authenticate_user | ||
| if api_token_blank || invalid_api_token |
There was a problem hiding this comment.
Does it matter if the api token is blank? All we care is if its valid or not? If they send a blank token then it won't be valid.
There was a problem hiding this comment.
This has to do with the one set. If there isnt one sent then noneone should be able to access it
|
|
||
| private | ||
| def authenticate_user | ||
| if api_token_not_set || invalid_api_token |
There was a problem hiding this comment.
I still don't know why you even care if its blank? Why not just make sure it doesn't match?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4 & Closes #6