Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert neetoEditor to a controlled component #1163

Closed
Tracked by #1100
deepakjosp opened this issue Jun 28, 2024 · 3 comments
Closed
Tracked by #1100

Convert neetoEditor to a controlled component #1163

deepakjosp opened this issue Jun 28, 2024 · 3 comments
Assignees
Labels
0.25D Estimate - 2 hours

Comments

@deepakjosp
Copy link
Contributor

deepakjosp commented Jun 28, 2024

Part of #1100

  • One of the main difficulties of using neetoEditor is that it can be only used as an uncontrolled component. This has a negative developer experience and needs the developers to directly use the editor API to mutate the content.
  • The controlled version of neetoEditor should not impact the performance.

@deepakjosp _a

@deepakjosp deepakjosp added the 1.5D Estimate - 12 hours label Jun 28, 2024
@deepakjosp deepakjosp mentioned this issue Jun 28, 2024
20 tasks
@deepakjosp
Copy link
Contributor Author

@AbhayVAshokan I was not able to work on this in this milestone because, I had to work for client couple of days in this milestone also. I have stretched the max to achieve the milestone, but this is beyond that and also requires extensive trials to make sure the changes doesn't impact the host apps. Could you please move this to next milestone?

@deepakjosp
Copy link
Contributor Author

@AbhayVAshokan I couldn't find a feasible performant approach to make the editor controlled. I explored a few similar products built using TipTap and nobody uses it as a controlled component. In one of the repos they explicitly mentioned that it's not recommended to use the editor as a controlled component, since the editor content must be serialized to get the HTML string to render the data the user typed in. Considering this it's better to use the setContent function from the editor instance to set the content of the editor from outside.

@AbhayVAshokan
Copy link
Member

Sounds good.

@deepakjosp deepakjosp added 0.25D Estimate - 2 hours and removed 1.5D Estimate - 12 hours labels Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.25D Estimate - 2 hours
Projects
None yet
Development

No branches or pull requests

2 participants