_sign_threshold now signs all subconditions for a public key #1294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1294 +/- ##
=======================================
Coverage 98.08% 98.08%
=======================================
Files 51 51
Lines 2294 2294
=======================================
Hits 2250 2250
Misses 44 44Continue to review full report at Codecov.
|
TimDaub
approved these changes
Mar 16, 2017
| # expect to get a list back. | ||
| ccffill = input_.fulfillment | ||
| subffills = ccffill.get_subcondition_from_vk(owner_before) | ||
| if not subffills: |
There was a problem hiding this comment.
This might be worth creating a ticket on Cryptoconditions that get_subcondition_from_vk should throw 🤔
Thoughts?
There was a problem hiding this comment.
Sure. All 3 todos in this method should be cc issues
ssadler
approved these changes
Mar 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1291
This pr makes sure that all subconditions for a given public key are fulfilled.