Remove extra fields from get_transaction #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhsimplex
reviewed
Sep 28, 2016
| response = self.connection.run(r.table('backlog').get(txid)) | ||
| response = self.connection.run(r.table('backlog') | ||
| .get(txid) | ||
| .without('assignee', 'assignment_timestamp') |
There was a problem hiding this comment.
Current coverage is 95.71% (diff: 100%)@@ master #646 diff @@
==========================================
Files 23 23
Lines 1308 1308
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 1254 1252 -2
- Misses 54 56 +2
Partials 0 0
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the
/api/v1/transactions/<txid>Web API @TimDaub noticed thatassigneeandassignment_timestampare returned for some calls.After further investigation I noticed this behavior happens only when the transaction is in the
backlogtable. This PR is to fix this misbehavior.