-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transfer multiple inputs rebase #125
Conversation
This reverts commit 3c9ff5c.
* yarn is usually installed globally and we never call the locally installed version
Codecov Report
@@ Coverage Diff @@
## master #125 +/- ##
==========================================
+ Coverage 82.26% 82.33% +0.06%
==========================================
Files 21 21
Lines 282 283 +1
==========================================
+ Hits 232 233 +1
Misses 50 50
Continue to review full report at Codecov.
|
As there are breaking changes, we will need to update everything. So I propose to handle this PR next week after we first create a new release of the JS driver including the metadata search: #124 for this week. So:
|
docs/Makefile
Outdated
@@ -26,7 +26,19 @@ html: | |||
@echo | |||
@echo "Build finished. The HTML pages are in $(BUILDDIR)/html." | |||
|
|||
<<<<<<< dfe221031eab9e09c54fb4c8bf0feb54fd250043 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rm merge conflict
When creating a transfer transaction the user has to specify the 'transaction' and the 'output_index' that he/she is spending. For example: Transaction.makeTransferTransaction(
[{ tx: transferTx, output_index: 0 }],
[aliceOutput],
metaData
) Travis do not mark this as an error, but maybe we want to change to camelcase and also change 'tx' for 'transaction': Transaction.makeTransferTransaction(
[{ transaction: transferTx, outputIndex: 0 }],
[aliceOutput],
metaData
) |
Anyways I would like to merge this PR. Is needed for sub-divisible assets. Can you @jernejpregelj check it? |
Rebase of #120
Don't know if working appropriately.