Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Progress indicator bar should have rounded corners #404

Closed
valterfatia opened this issue May 19, 2020 · 4 comments
Closed

Progress indicator bar should have rounded corners #404

valterfatia opened this issue May 19, 2020 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@valterfatia
Copy link
Contributor

Considering the bar only has 4px in height the corners will be fully rounded on both ends.
@chanceaclark chanceaclark added the good first issue Good for newcomers label Jun 15, 2020
@chanceaclark
Copy link
Contributor

@valterfatia what is the border-radius for the rounded ends?

@valterfatia
Copy link
Contributor Author

4px! Our standard measure

@chanceaclark chanceaclark added the enhancement New feature or request label Jul 31, 2020
@bc-Shuvy
Copy link

Just confirming we reviewed the design for this, decision seems to be it's too small for the radius to appear right - current design stands.

@chanceaclark
Copy link
Contributor

@valterfatia @bc-Shuvy can we close this issue then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chanceaclark @valterfatia @bc-Shuvy