Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation request - difference between cart.discountAmount and cart.discounts.discountedAmount #387

Closed
daisy1754 opened this issue Aug 26, 2018 · 2 comments
Assignees

Comments

@daisy1754
Copy link

More detailed documentation will help SDK users a lot :)

For instance, one may think cart.discountAmount is a sum of cart.discounts.discountedAmount, but in reality these two seems to be completely independent value (!)
My current understanding is cart.discountAmount is a cart-level discount while cart.discounts is a user-entered coupons.

Can these information explicitly added to https://github.com/bigcommerce/checkout-sdk-js/blob/master/docs/interfaces/cart.md ?
screen shot 2018-08-25 at 7 39 01 pm

@davidchin
Copy link
Contributor

Yes, the current documentation definitely has areas that could be improved upon (i.e.: descriptions for returning objects). We'll look into it.

@bc-0dp
Copy link
Collaborator

bc-0dp commented Feb 19, 2024

Closing this, as discussion can take place on the PR.

@bc-0dp bc-0dp closed this as completed Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants