feat(catalog): CATALOG-3161 retail price range #1199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Autotagging @bigcommerce/storefront-team @davidchin |
davidwrpayne
approved these changes
May 15, 2018
|
@Souldjinn This needs a rebase after David's change |
davidwrpayne
approved these changes
May 29, 2018
| <abbr title="{{lang 'products.including_tax'}}">{{lang 'products.price_with_tax' tax_label=price_range.min.tax_label}}</abbr> | ||
| <span data-product-price-without-tax class="price price--rrp">{{price.retail_price_range.min.without_tax.formatted}} - {{price.retail_price_range.max.without_tax.formatted}}</span> | ||
| {{#if schema_org}} | ||
| <meta itemprop="availability" content="{{product.availability}}"> |
and make it strike through.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Show a retail price range if one exists and make it strike through.
This pull request is dependent on another, and will basically only show if all fo the variants to this product contain a retail price.
I didnt add the message that says "Without Tax" because retail price wont ever be calculated with tax anyway so its kind of redundant/misleading.
Tickets / Documentation
The below ticket must be finished before this can be merged
Screenshots (if appropriate)