fix(catalog): CATALOG-2913 individual low inventory count for skus #1234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setting for skus. We were not properly switching back and forth
between skus that were above and below their own respective
threshholds.
|
Autotagging @bigcommerce/storefront-team @davidchin |
|
@Ubersmake Can you test this? |
bc-jz
reviewed
May 23, 2018
| @@ -463,6 +463,9 @@ export default class ProductDetails { | |||
| // if the stock container is hidden, show | |||
| viewModel.stock.$container.removeClass('u-hiddenVisually'); | |||
|
|
|||
| viewModel.stock.$input.text(data.stock); | |||
| } else { | |||
| viewModel.stock.$container.addClass('u-hiddenVisually'); | |||
| viewModel.stock.$input.text(data.stock); | |||
There was a problem hiding this comment.
shouldn't this text be updating to be an empty string since the data.stock does not exist in this case?
There was a problem hiding this comment.
turns it out does not matter....this is working as is
|
💚 this is working for me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
address STOCK_LEVEL_DISPLAY_SHOW_WHEN_LOW
setting for skus. We were not properly switching back and forth
between skus that were above and below their own respective
threshholds.
Tickets / Documentation
Dependency
in order for this to work completely, this FE change depends on a BC pr
please see ticket for additional info.