Support VCF annotation ANN field in vcf2adam and adam2vcf #1044

Closed
heuermh opened this Issue Jun 5, 2016 · 5 comments

Comments

Projects
3 participants
@heuermh
Member

heuermh commented Jun 5, 2016

Schema were added to bdg-formats in bigdatagenomics/bdg-formats#67.

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Nov 8, 2016

Member

Should be resolved by #1250.

Member

fnothaft commented Nov 8, 2016

Should be resolved by #1250.

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Nov 11, 2016

Member

#1250 doesn't fully address this yet.

Mappings between the VCF INFO reserved key ANN and calls to TranscriptEffectConverter.convertToTranscriptEffects and TranscriptEffectConverter.convertToVcfInfoAnnValue need to be added to VariantAnnotationConverter as part of further refactoring.

Member

heuermh commented Nov 11, 2016

#1250 doesn't fully address this yet.

Mappings between the VCF INFO reserved key ANN and calls to TranscriptEffectConverter.convertToTranscriptEffects and TranscriptEffectConverter.convertToVcfInfoAnnValue need to be added to VariantAnnotationConverter as part of further refactoring.

@jpdna

This comment has been minimized.

Show comment
Hide comment
@jpdna

jpdna Nov 16, 2016

Member

#1271 should address this correct?

Member

jpdna commented Nov 16, 2016

#1271 should address this correct?

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Nov 16, 2016

Member

No, I haven't written the code yet. :)

Look for a new pull request that says it fixes this issue.

Member

heuermh commented Nov 16, 2016

No, I haven't written the code yet. :)

Look for a new pull request that says it fixes this issue.

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Jan 5, 2017

Member

Fixed by #1288

Member

heuermh commented Jan 5, 2017

Fixed by #1288

@heuermh heuermh closed this Jan 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment