FastqRecordConverter needs cleanup and tests

[fnothaft]

We need to refactor org.bdgenomics.adam.converters.FastqRecordConverter as there's a lot of code duplication between the AlignmentRecord and Fragment code paths. Also, there apparently are no tests for this class, which is surprising!

[zyxue]

I would like to try to fix this issue, how do I get started?

[heuermh]

@zyxue unit tests would be a good place to start. Once there is some test coverage, then start cleaning things up!

[zyxue]

Do I need spark to start the development? I just run another test suite, FastaConverter.scala, on IntelliJ, and seems the tests passed successfully.

[heuermh]

The maven build (and by extension, the build in IntelliJ) is self contained.

You will need Spark to run the adam-submit and adam-shell commands in the bin directory though.

[zyxue]

Do you know why would the input be of type (Void, Text), see this line? Where is Void from, why not just Text?