Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

private ADAMContext constructor? #1296

Closed
ryan-williams opened this issue Nov 30, 2016 · 1 comment
Closed

private ADAMContext constructor? #1296

ryan-williams opened this issue Nov 30, 2016 · 1 comment

Comments

@ryan-williams
Copy link
Member

@ryan-williams ryan-williams commented Nov 30, 2016

I'm upgrading from 0.20.0 to something closer to head, and I see that 480c1f4 made the ADAMContext ctor private, so I am changing several call-sites from:

val adamContext = new ADAMContext(sc)

to

val adamContext: ADAMContext = sc

Any good reasons for the ctor itself to be private?

@heuermh
Copy link
Member

@heuermh heuermh commented Nov 30, 2016

I've also noticed this in some adam-shell examples in docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.