private ADAMContext constructor? #1296

Closed
ryan-williams opened this Issue Nov 30, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@ryan-williams
Member

ryan-williams commented Nov 30, 2016

I'm upgrading from 0.20.0 to something closer to head, and I see that 480c1f4 made the ADAMContext ctor private, so I am changing several call-sites from:

val adamContext = new ADAMContext(sc)

to

val adamContext: ADAMContext = sc

Any good reasons for the ctor itself to be private?

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Nov 30, 2016

Member

I've also noticed this in some adam-shell examples in docs

Member

heuermh commented Nov 30, 2016

I've also noticed this in some adam-shell examples in docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment