BroadcastRegionJoin has serialization failures #1334

Closed
fnothaft opened this Issue Jan 1, 2017 · 1 comment

Comments

Projects
2 participants
@fnothaft
Member

fnothaft commented Jan 1, 2017

Two issues:

  • Unless your left side is a VariantContextRDD, the wrong IntervalTreeSerializer gets picked due to type erasure (last one wins, apparently)
  • Serializing a VariantContext with a FieldSerializer fails

@fnothaft fnothaft self-assigned this Jan 1, 2017

@fnothaft fnothaft referenced this issue in bigdatagenomics/utils Jan 1, 2017

Closed

Type erasure confounds IntervalTreeSerializer... #96

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Jan 3, 2017

Member

Cross linking to bigdatagenomics/utils#97.

Member

fnothaft commented Jan 3, 2017

Cross linking to bigdatagenomics/utils#97.

fnothaft added a commit to fnothaft/adam that referenced this issue Jan 3, 2017

[ADAM-1334] Clean up serialization issues in Broadcast region join.
Resolves #1334. Eliminates type erasure problems by having different concrete
implementations per each broadcast. Depends on
bigdatagenomics/utils#97.

@heuermh heuermh modified the milestone: 0.21.0 Jan 4, 2017

fnothaft added a commit to fnothaft/adam that referenced this issue Jan 5, 2017

[ADAM-1334] Clean up serialization issues in Broadcast region join.
Resolves #1334. Eliminates type erasure problems by having different concrete
implementations per each broadcast. Depends on
bigdatagenomics/utils#97.

fnothaft added a commit to fnothaft/adam that referenced this issue Jan 5, 2017

[ADAM-1334] Clean up serialization issues in Broadcast region join.
Resolves #1334. Eliminates type erasure problems by having different concrete
implementations per each broadcast. Depends on
bigdatagenomics/utils#97.

fnothaft added a commit to fnothaft/adam that referenced this issue Jan 6, 2017

[ADAM-1334] Clean up serialization issues in Broadcast region join.
Resolves #1334. Eliminates type erasure problems by having different concrete
implementations per each broadcast. Depends on
bigdatagenomics/utils#97.

@heuermh heuermh closed this in #1336 Jan 6, 2017

heuermh added a commit that referenced this issue Jan 6, 2017

[ADAM-1334] Clean up serialization issues in Broadcast region join.
Resolves #1334. Eliminates type erasure problems by having different concrete
implementations per each broadcast. Depends on
bigdatagenomics/utils#97.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment