Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BroadcastRegionJoin has serialization failures #1334

Closed
fnothaft opened this issue Jan 1, 2017 · 1 comment
Closed

BroadcastRegionJoin has serialization failures #1334

fnothaft opened this issue Jan 1, 2017 · 1 comment
Assignees
@fnothaft
Milestone
0.21.0

Comments

@fnothaft
Copy link
Member

fnothaft commented Jan 1, 2017

Two issues:

  • Unless your left side is a VariantContextRDD, the wrong IntervalTreeSerializer gets picked due to type erasure (last one wins, apparently)
  • Serializing a VariantContext with a FieldSerializer fails
@fnothaft fnothaft self-assigned this Jan 1, 2017
@fnothaft fnothaft mentioned this issue Jan 1, 2017
Closed
@fnothaft
Copy link
Member Author

fnothaft commented Jan 3, 2017

Cross linking to bigdatagenomics/utils#97.

fnothaft added a commit to fnothaft/adam that referenced this issue Jan 3, 2017
@fnothaft
[ADAM-1334] Clean up serialization issues in Broadcast region join.
ef72554 
Resolves bigdatagenomics#1334. Eliminates type erasure problems by having different concrete
implementations per each broadcast. Depends on
bigdatagenomics/utils#97.
@fnothaft fnothaft mentioned this issue Jan 3, 2017
Merged
@heuermh heuermh modified the milestone: 0.21.0 Jan 4, 2017
fnothaft added a commit to fnothaft/adam that referenced this issue Jan 5, 2017
@fnothaft
[ADAM-1334] Clean up serialization issues in Broadcast region join.
949970b 
Resolves bigdatagenomics#1334. Eliminates type erasure problems by having different concrete
implementations per each broadcast. Depends on
bigdatagenomics/utils#97.
fnothaft added a commit to fnothaft/adam that referenced this issue Jan 5, 2017
@fnothaft
[ADAM-1334] Clean up serialization issues in Broadcast region join.
43e2519 
Resolves bigdatagenomics#1334. Eliminates type erasure problems by having different concrete
implementations per each broadcast. Depends on
bigdatagenomics/utils#97.
fnothaft added a commit to fnothaft/adam that referenced this issue Jan 6, 2017
@fnothaft
[ADAM-1334] Clean up serialization issues in Broadcast region join.
9c0668b 
Resolves bigdatagenomics#1334. Eliminates type erasure problems by having different concrete
implementations per each broadcast. Depends on
bigdatagenomics/utils#97.
heuermh pushed a commit that referenced this issue Jan 6, 2017
@fnothaft @heuermh
[ADAM-1334] Clean up serialization issues in Broadcast region join.
5dcd70b 
Resolves #1334. Eliminates type erasure problems by having different concrete
implementations per each broadcast. Depends on
bigdatagenomics/utils#97.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fnothaft fnothaft

Labels
None yet
Projects
None yet
Milestone
0.21.0
Development

No branches or pull requests
2 participants
@heuermh @fnothaft