/adam

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate unused ConcreteADAMRDDFunctions class #1580

Closed
fnothaft opened this Issue Jun 23, 2017 · 2 comments

Comments

Assignees

@fnothaft fnothaft

Labels
Projects
Triage in Release 0.24.0
Milestone
  0.24.0
2 participants
@fnothaft @heuermh
@fnothaft
Member

fnothaft commented Jun 23, 2017

I was considering doing this in #1391, as it would eliminate the classtag hacking I've added in 92e296e. However, I don't want this to come in to #1391, because I'd rather it get a standalone review, etc. Here's the to-do:

  • Eliminate unused ConcreteADAMRDDFunctions class
  • Move functionality from ADAMRDDFunctions into GenomicRDD
  • Change GenomicRDD from a trait into an abstract class with a view bound on T: Manifest, which eliminates the need to hack the classtags

@fnothaft fnothaft added the enhancement label Jun 23, 2017

@fnothaft fnothaft added this to the 0.23.0 milestone Jun 23, 2017

@fnothaft fnothaft self-assigned this Jun 23, 2017

@fnothaft fnothaft referenced this issue Jul 7, 2017

Merged

[ADAM-1018] Add support for Spark SQL Datasets. #1391

4 of 4 tasks complete

@fnothaft fnothaft modified the milestones: 0.24.0, 0.23.0 Jul 12, 2017

@heuermh heuermh added this to Triage in Release 0.24.0 Jan 4, 2018

@heuermh

This comment has been minimized.

Sign in to view
Member

heuermh commented Jan 9, 2018

@fnothaft move to 0.25.0?
@fnothaft

This comment has been minimized.

Sign in to view
Member

fnothaft commented Jan 9, 2018

I think this is keep in 0.24.0, but let me confirm.

fnothaft added a commit to fnothaft/adam that referenced this issue Feb 21, 2018

@fnothaft
[ADAM-1580] Eliminate ADAMRDDFunctions classes. 
Resolves bigdatagenomics#1580. Does not compile due to abstract classes not implemented.
8f19161

@fnothaft fnothaft referenced this issue Feb 21, 2018

Merged

Make Spark SQL APIs supported across all types #1921

5 of 5 tasks complete

fnothaft added a commit to fnothaft/adam that referenced this issue Mar 7, 2018

@fnothaft
[ADAM-1580] Eliminate ADAMRDDFunctions classes. 
Resolves bigdatagenomics#1580. Does not compile due to abstract classes not implemented.
8ad5efe

fnothaft added a commit to fnothaft/adam that referenced this issue Mar 7, 2018

@fnothaft
[ADAM-1580] Eliminate ADAMRDDFunctions classes. 
Resolves bigdatagenomics#1580. Does not compile due to abstract classes not implemented.
492eb4c

fnothaft added a commit to fnothaft/adam that referenced this issue Mar 7, 2018

@fnothaft
[ADAM-1580] Eliminate ADAMRDDFunctions classes. 
Resolves bigdatagenomics#1580. Does not compile due to abstract classes not implemented.
b69bdd6

fnothaft added a commit to fnothaft/adam that referenced this issue Mar 15, 2018

@fnothaft
[ADAM-1580] Eliminate ADAMRDDFunctions classes. 
Resolves bigdatagenomics#1580. Does not compile due to abstract classes not implemented.
1c7f10e

@heuermh heuermh closed this in #1921 Mar 20, 2018

heuermh added a commit that referenced this issue Mar 20, 2018

@fnothaft @heuermh
[ADAM-1580] Eliminate ADAMRDDFunctions classes. 
Resolves #1580. Does not compile due to abstract classes not implemented.
a3ba0b7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment