[ADAM-1132] Fix improper quoting of bash args in adam-shell. #1133

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
@fnothaft
Member

fnothaft commented Aug 26, 2016

Resolves #1132. Eliminates the need for append_to_option.py, so I removed said file.

TIL http://stackoverflow.com/questions/1668649/how-to-keep-quotes-in-args/1669548#1669548

[ADAM-1132] Fix improper quoting of bash args in adam-shell.
Resolves #1132. Eliminates the need for `append_to_option.py`, so I removed said
file.
@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Aug 26, 2016

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1428/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1428/
Test PASSed.

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Aug 26, 2016

Member

Works for me.

Member

heuermh commented Aug 26, 2016

Works for me.

@ryan-williams

This comment has been minimized.

Show comment
Hide comment
@ryan-williams

ryan-williams Aug 26, 2016

Member

wfm2, thx for quick fix frank

Member

ryan-williams commented Aug 26, 2016

wfm2, thx for quick fix frank

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Aug 26, 2016

Member

Merged as commit a55d2cb.

Thank you, @fnothaft @ryan-williams

Member

heuermh commented Aug 26, 2016

Merged as commit a55d2cb.

Thank you, @fnothaft @ryan-williams

@heuermh heuermh closed this Aug 26, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment