New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADAM-1362] Fixing issue where FromKnowns consensus model fails if no reads hit a target. #1363
Merged
heuermh
merged 1 commit into
bigdatagenomics:master
from
fnothaft:issues/1362-fromknowns-empty-target
Jan 23, 2017
Merged
[ADAM-1362] Fixing issue where FromKnowns consensus model fails if no reads hit a target. #1363
heuermh
merged 1 commit into
bigdatagenomics:master
from
fnothaft:issues/1362-fromknowns-empty-target
Jan 23, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… reads hit a target. Fixes bigdatagenomics#1362: * Adding ConsensusGeneratorFromKnownsSuite. * ConsensusGeneratorFromKnowns drops any targets that did not get hit with any reads, instead of trying to identify the full reference region overlapped by reads. While this case (target with no reads) cannot happen in the FromReads consensus model, it can happen in the FromKnowns model (e.g., use all known INDELs from 1000G with a WES dataset). * Additionally, tracked down a minor off by one bug in RealignIndels that caused one index in the consensus sequence to not get tested. This could cause reads that aligned to the end of the target to not get realigned. * To improve legibility, broke up a set of long lines in RealignIndels.
Test PASSed. |
fnothaft
added a commit
to fnothaft/avocado
that referenced
this pull request
Jan 23, 2017
Resolves bigdatagenomics#200. Depends on bigdatagenomics/adam#1363. * Adds a ConsensusRealigner that uses the main Realigner to realign reads, which are then fed into the variant discovery engine with loose filters. Any INDEL variants that are discovered are then fed in to ADAM's INDEL realignment engine as known INDELs. * Uses this realignment mode in the BiallelicGenotyperSuite to clean up a previously failing test. * Adds this to the Reassemble CLI as a `-use_consensus_realigner` switch.
heuermh
approved these changes
Jan 23, 2017
Thank you, @fnothaft! |
fnothaft
added a commit
to fnothaft/avocado
that referenced
this pull request
Jan 25, 2017
Resolves bigdatagenomics#200. Depends on bigdatagenomics/adam#1363. * Adds a ConsensusRealigner that uses the main Realigner to realign reads, which are then fed into the variant discovery engine with loose filters. Any INDEL variants that are discovered are then fed in to ADAM's INDEL realignment engine as known INDELs. * Uses this realignment mode in the BiallelicGenotyperSuite to clean up a previously failing test. * Adds this to the Reassemble CLI as a `-use_consensus_realigner` switch.
fnothaft
added a commit
to fnothaft/avocado
that referenced
this pull request
Feb 28, 2017
Resolves bigdatagenomics#200. Depends on bigdatagenomics/adam#1363. * Adds a ConsensusRealigner that uses the main Realigner to realign reads, which are then fed into the variant discovery engine with loose filters. Any INDEL variants that are discovered are then fed in to ADAM's INDEL realignment engine as known INDELs. * Uses this realignment mode in the BiallelicGenotyperSuite to clean up a previously failing test. * Adds this to the Reassemble CLI as a `-use_consensus_realigner` switch.
fnothaft
added a commit
to fnothaft/avocado
that referenced
this pull request
Mar 1, 2017
Resolves bigdatagenomics#200. Depends on bigdatagenomics/adam#1363. * Adds a ConsensusRealigner that uses the main Realigner to realign reads, which are then fed into the variant discovery engine with loose filters. Any INDEL variants that are discovered are then fed in to ADAM's INDEL realignment engine as known INDELs. * Uses this realignment mode in the BiallelicGenotyperSuite to clean up a previously failing test. * Adds this to the Reassemble CLI as a `-use_consensus_realigner` switch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1362: