Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making TreeRegionJoin consistent with ShuffleRegionJoin #1515

Conversation

@devin-petersohn
Copy link
Member

@devin-petersohn devin-petersohn commented May 5, 2017

Resolves #1514

@devin-petersohn
Copy link
Member Author

@devin-petersohn devin-petersohn commented May 5, 2017

This is just something I found along the way. I split it out of #1324 because this has a chance to potentially break some things.

@coveralls
Copy link

@coveralls coveralls commented May 5, 2017

Coverage Status

Coverage remained the same at 81.783% when pulling 1f7c9b4 on devin-petersohn:issue#1514TreeRegionJoinRefactor into 36d8e0b on bigdatagenomics:master.

Copy link
Member

@fnothaft fnothaft left a comment

Thanks @devin-petersohn! LGTM.

@AmplabJenkins
Copy link

@AmplabJenkins AmplabJenkins commented May 5, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1973/
Test PASSed.

@fnothaft fnothaft merged commit c77c600 into bigdatagenomics:master May 5, 2017
3 checks passed
3 checks passed
codacy/pr Good work! A positive pull request.
Details
coverage/coveralls Coverage remained the same at 81.783%
Details
default Merged build finished.
Details
@fnothaft
Copy link
Member

@fnothaft fnothaft commented May 5, 2017

Merged! Thanks @devin-petersohn!

@devin-petersohn
Copy link
Member Author

@devin-petersohn devin-petersohn commented May 5, 2017

Thanks @fnothaft!

@heuermh heuermh added this to the 0.23.0 milestone Dec 7, 2017
@heuermh heuermh added this to Completed in Release 0.23.0 Jan 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.